streams: make streams lazy by default #673
Conversation
Makes streams lazy by default so crypto does not need to monky patch them in order to get good performance. This helps the state objects become part of the private api in nodejs#445.
|
The goal seems to be that one can subclass a stream, but avoid the cost of instantiating a stream when instantiating the class (or defer that until it's absolutely needed.) My initial reaction to this is -0. It seems a bit like the error tracking that {wa,i}s being done in Writable streams for the sole benefit of |
|
@chrisdickinson so in crypto streams if you just use the sync update digest/final methods you never actually need to initialize the stream. The general use case from a consumer api would be creating 'streamable' objects that can you a fast path for synchronous usage and a queued path for dealing with async data. |
|
-1. crypto needs it because it (hash, etc.) has dual interface. the real problem is that hash shouldn't be a transform: transform is supposed to output a stream. Hash is a single buffer with fixed length. It makes sense for it be Writable, but not readable. |
|
Ciphers though On Fri, Jan 30, 2015, 5:08 PM Vladimir Kurchatkin notifications@github.com
|
|
@calvinmetcalf my bad, you are right. Dual interfaces are still bad. Deprecating one and blessing the other is the way I like. |
|
Ideally I'd like to expose the streaming versions on top of the existing versions – as a |
|
So currently hash does emit it's value in the stream but digest and verify On Fri, Jan 30, 2015, 5:22 PM Chris Dickinson notifications@github.com
|
|
Er sign and verify On Fri, Jan 30, 2015, 6:08 PM Calvin Metcalf calvin.metcalf@gmail.com
|
|
Closing this. Lazy initialization encourages more mixed-usage APIs, which we don't want to encourage. |
Makes streams lazy by default so crypto does not need to monky patch them in
order to get good performance. This helps the state objects become part of the
private api in #445.
Other discussion at nodejs/readable-stream#109
Ran the bench marks on crypto and they seemed to be compatible (unlike my first attempt) somebody should definitely check me on that.